sdods lint: "Scenario must carry exactly one layer tag" on every scenario I have

Asked 16 Nov 202012,840 views2 answers

34votes

Ported a feature file over from our old cucumber project and lint rejects all of it.

bash

sdods lint -p demo-shop

text

✖ features/auth/login.feature:7  tags/layer  Scenario must carry exactly one layer tag (@ui, @api, @hybrid); found none.
✖ features/auth/login.feature:7  tags/suite  Scenario must carry exactly one suite tag (@smoke, @regression, @sanity); found none.
✖ features/auth/login.feature:14  tags/layer  Scenario must carry exactly one layer tag (@ui, @api, @hybrid); found none.
✖ features/auth/login.feature:14  tags/suite  Scenario must carry exactly one suite tag (@smoke, @regression, @sanity); found none.
1 feature file(s), 4 error(s), 0 warning(s)

The Gherkin is valid — it parses, the steps exist. What is a "layer tag", and does it belong on the Feature or on every single Scenario?

lint ui

asked by Marijn Kuiper18,840 · 16 Nov 2020

2 answers

41votes✓
Accepted answer
The layer tag is not decoration, it picks the runner target. @ui runs in a browser context, @api runs with the API client and no browser, @hybrid gets both. Without it there is nothing to run the scenario as, so it is an error rather than a warning.
You do not have to repeat it. Tags on the Feature: line are inherited by every scenario under it, so a whole file that is one layer gets one tag:
gherkin
```
@ui @auth
Feature: Login
  As a shopper I want to sign in so that I can see the inventory.

  @smoke @har:login
  Scenario: Successful login shows the products
    When I login with "standard_user" and "{{standardPassword}}"
    Then I should be on the inventory page

  @regression
  Scenario: Generic UI steps work against the login form
    When I fill the element with test id "username" with "standard_user"
    Then the page URL should contain "/inventory.html"
```
Suite tags I would keep per scenario, because they are the thing you filter a run on and they differ inside a file.
If the layout already makes the layer obvious, --fix-tags will write it in for you:
bash
```
sdods lint -p demo-shop --fix-tags
```
It only inserts a tag when it can derive one — a features/ui/ path segment or the module's declared layers. It will not guess a suite tag for you.
answered by Reeta Nandalmaintainer41,280 · 16 Nov 2020
12votes
Adding to that: the reason inheritance is safe for the layer and awkward for the suite is that the suite tag also selects the screenshot policy. In the project yaml:
yaml
```
screenshots:
  policy:
    default: on-failure
    '@smoke': scenario
    '@regression': step
    '@sanity': scenario
```
If you put @regression on the Feature line you have quietly signed every scenario in the file up for a screenshot per step. Fine for a five-step file, less fine for a big one.
answered by Tomas Brekkemaintainer33,915 · 18 Nov 2020

Have the same question?

Ask it with the command you ran and the output you got, and it will be answered here.

Ask a question

sdods lint: "Scenario must carry exactly one layer tag" on every scenario I have

2 answers

Related