Scenario broke, ran the healer, got a proposal. The patch swaps a page-object locator for a class chain:
this.heal.locator('.f-row--2 .f-ctl input', { description: 'promo code' })The input has a visible label reading "Promo code". So there is an obviously better locator and it picked the worst one on the list. Do I reject and re-run, or fix it in place and accept?
Accepted answer
Reject it, but not because the locator is bad. Reject it because the proposal is telling you something true and you would be deleting the message.
The healer picks from what the failing run actually gave it: the error, the ARIA snapshot and the locator statistics. getByLabel('Promo code') is only available to it if that label is associated with the input in the accessibility tree. A visible label that is not wired to the control — no for, no aria-labelledby, wrapped in a div instead of a label — is invisible to the snapshot, and to a screen reader.
So the CSS chain is the healer honestly reporting that the element has no accessible name.
sdods proposals reject <id> --reason "input has no accessible name; fixing the page instead"Fix the markup, re-run the scenario, and the locator you wanted becomes available to everyone including the next heal.
If the label really is wired up and the healer still went to CSS, that is worth a separate thread — paste heal_locator_stats for the fingerprint.
On the mechanical part of the question: do not edit files under proposals/<id>/ and then accept. The manifest is the record of what the agent proposed, and hand-editing the staged files makes that record disagree with what you actually applied — which matters the first time somebody asks why a locator in main is not the one in the proposal they reviewed.
Accept it or reject it as it stands; make your own change as your own commit.
We hit this often enough that we started running analyze_locators over a module before letting the healer near it. It flags the controls with no accessible name up front, so the first heal proposal on that module is usually a sensible one instead of a class chain.
Not a fix, just less annoying.
Have the same question?
Ask it with the command you ran and the output you got, and it will be answered here.
Ask a question